Skip to content

docs: clarify OpenScene architecture and improve generation planning - #198

Merged
sjungwon03 merged 7 commits into
devfrom
feat/197-trust-planning
Aug 4, 2026
Merged

docs: clarify OpenScene architecture and improve generation planning#198
sjungwon03 merged 7 commits into
devfrom
feat/197-trust-planning

Conversation

@sjungwon03

@sjungwon03 sjungwon03 commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

  • add a README architecture diagram and explain renderer, preload, main-process, shared-core, local-data, and provider boundaries
  • mark historical product/AI-direction docs clearly and point to the current README capability boundary
  • plan exact legal generation shot combinations before disclosed rounding (Google Gemini 10s now plans 6s + 4s)
  • update TypeMCP to 0.3.1, resolving the MCP SDK transitively reported production dependency advisory

Verification

  • npm test -- --reporter=dot — 125 files / 739 tests passed
  • npm run typecheck — passed
  • npm run build — passed
  • npm --prefix mobile run typecheck — passed
  • npm audit --omit=dev --audit-level=moderate — 0 vulnerabilities
  • git diff --check — passed

Scope note

The checkout contains unrelated, uncommitted first-run onboarding logo changes. They are deliberately excluded from this PR.

Closes #197

@sjungwon03 sjungwon03 added type:docs Documentation change status:ready Ready for implementation area:core Electron main/preload/shared core area:docs Documentation/community area:security Security and privacy size:M Medium change labels Aug 3, 2026
@sjungwon03 sjungwon03 self-assigned this Aug 3, 2026
@sjungwon03
sjungwon03 marked this pull request as ready for review August 3, 2026 11:33
sjungwon03-ai
sjungwon03-ai reviewed Aug 3, 2026
View reviewed changes

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exact-head CI run passed, but its GITHUB_TOKEN currently has write access to every available permission because the workflow declares no least-privilege permissions block. Please restrict it (for this verification job, contents: read should suffice) before relying on it for release-sensitive changes.

@sjungwon03-ai sjungwon03-ai added the review:commented Review comments posted label Aug 3, 2026
@sjungwon03

sjungwon03 commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Addressed the CI least-privilege finding in d8c6878: the verification workflow now declares top-level permissions: contents: read, with a source-contract regression test. Focused governance test and root typecheck pass locally. Please re-review the current head.

sjungwon03-ai
sjungwon03-ai approved these changes Aug 4, 2026
View reviewed changes

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exact-head CI run passed and the workflow now restricts GITHUB_TOKEN to contents: read; the bounded planner correctly prefers legal exact duration combinations.

@sjungwon03-ai sjungwon03-ai added review:approved Latest-head review approved and removed review:commented Review comments posted labels Aug 4, 2026
@sjungwon03
sjungwon03 merged commit d911ce7 into dev Aug 4, 2026
1 check passed
@sjungwon03
sjungwon03 deleted the feat/197-trust-planning branch August 4, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjungwon03-ai sjungwon03-ai sjungwon03-ai approved these changes

Assignees

@sjungwon03 sjungwon03

Labels

area:core Electron main/preload/shared core area:docs Documentation/community area:security Security and privacy review:approved Latest-head review approved size:M Medium change status:ready Ready for implementation type:docs Documentation change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve architecture docs, storyboard planning, and MCP dependency security

2 participants

@sjungwon03 @sjungwon03-ai